Skip to content

Support fetching API Key from secrets manager #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2019
Merged

Support fetching API Key from secrets manager #29

merged 1 commit into from
Nov 14, 2019
+15 −11

Conversation

tianchu
Copy link
Collaborator

@tianchu tianchu commented Nov 14, 2019

What does this PR do?

Support fetching DD API Key from Secrets Manager using the environment variable DD_API_KEY_SECRET_ARN.

@tianchu tianchu requested a review from a team as a code owner November 14, 2019 02:51
DarcyRaynerDD
DarcyRaynerDD approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@DarcyRaynerDD DarcyRaynerDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianchu tianchu merged commit d12d9cb into master Nov 14, 2019
@tianchu tianchu deleted the tian.chu/fetch-dd-api-key-from-secrets-manager branch November 14, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarcyRaynerDD DarcyRaynerDD DarcyRaynerDD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tianchu @DarcyRaynerDD